Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

New weights#951

Merged
NachoPal merged 2 commits intorelease-parachains-v7.0.0from
nacho/new-weights-parachains-v7.0.0
Feb 3, 2022
Merged

New weights#951
NachoPal merged 2 commits intorelease-parachains-v7.0.0from
nacho/new-weights-parachains-v7.0.0

Conversation

@NachoPal
Copy link
Contributor

@NachoPal NachoPal commented Feb 3, 2022

No description provided.

@NachoPal NachoPal added A0-pleasereview B0-silent Changes should not be mentioned in any release notes T7-system_parachains This PR/Issue is related to System Parachains. labels Feb 3, 2022
coderobe
coderobe reviewed Feb 3, 2022
View reviewed changes
Copy link
Contributor

@coderobe coderobe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that due to the recent DB cache size increase (128 -> 1024) many of these drift quite a bit, usually downwards

@coderobe
Copy link
Contributor

coderobe commented Feb 3, 2022 •
edited
Loading

I've only highlighted some of the bigger changes - the recent DB cache size change has improved perf and thus lowered the weights across the board (i think?)

@shawntabrizi
Copy link
Member

shawntabrizi commented Feb 3, 2022

Due to the recent DB cache size increase (128 -> 1024) many of these drift quite a bit, usually downwards

This change will not affect the weights you are pointing out at all.

@gilescope
Copy link
Contributor

gilescope commented Feb 3, 2022 •
edited
Loading

hmm, well we could rerun and check that the results are stable and it is not an aberration. Do we know of any PRs that should dramatically improved things?

gilescope
gilescope approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems in line changes in general. As long as we are ok with 0 weight for remarks then looks reasonable. (remark_with_event is already 0 weighted)

@apopiak
Copy link
Contributor

apopiak commented Feb 3, 2022

just FYI: the Substrate weights went down when running the benchmarks with optimizations: paritytech/substrate#10692

NachoPal
NachoPal commented Feb 3, 2022
View reviewed changes
@NachoPal NachoPal merged commit be8b8e6 into release-parachains-v7.0.0 Feb 3, 2022
@NachoPal NachoPal deleted the nacho/new-weights-parachains-v7.0.0 branch February 3, 2022 19:55
gilescope pushed a commit that referenced this pull request Feb 9, 2022
@NachoPal @gilescope
new weights for release-parachains-v7.0.0 (#951)
d198a4c
paritytech-processbot bot pushed a commit that referenced this pull request Feb 10, 2022
@gilescope @NachoPal
new weights for release-parachains-v7.0.0 (#951) (#973)
cc7116d 
Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chevdor chevdor Awaiting requested review from chevdor

@EgorPopelyaev EgorPopelyaev Awaiting requested review from EgorPopelyaev

3 more reviewers

@gilescope gilescope gilescope approved these changes

@coderobe coderobe coderobe left review comments

@ggwpez ggwpez ggwpez left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

B0-silent Changes should not be mentioned in any release notes T7-system_parachains This PR/Issue is related to System Parachains.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@NachoPal @coderobe @shawntabrizi @gilescope @apopiak @ggwpez